Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is two separate optimizations.
The first is speeding up
hash(::Union{Float16, Float32})
using the fact that they always are within the range ofInt64
so you don't need to check that (or check whether they are within theUInt64
range.The second is that
AbstractFloat
s andInteger
s will never have a denominator that isn't 1, so we can change the rules of hashing to not hash the denominator if it is 1.