Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Add additional flags to OSLIBS #50017

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented May 31, 2023

- Remove file src/mach_dyld_atfork.tbd
- Fixes JuliaLang#49976
@benz0li
Copy link
Contributor Author

benz0li commented May 31, 2023

Cross reference: macports/macports-ports#18905

Same patch. But only applied if darwin version < 19 (macOS version < 10.15 (Catalina)).

@ViralBShah ViralBShah added domain:building Build system, or building Julia or its dependencies system:mac Affects only macOS labels Jun 2, 2023
@benz0li
Copy link
Contributor Author

benz0li commented Jun 2, 2023

@quentinmit The MacPorts build for macOS 10.14 (Mojave) now succeeds.
ℹ️ It does not build for older versions ('OS X'/macOS 10.10 - 10.13 (Yosemite - High Sierra)) on MacPorts, though.

src/Makefile Outdated Show resolved Hide resolved
src/Makefile Outdated Show resolved Hide resolved
@benz0li benz0li changed the title macOS: Add additional CLANG_LDFLAGS macOS: Add additional flags to OSLIBS Jun 28, 2023
@benz0li benz0li marked this pull request as draft June 28, 2023 04:31
@benz0li
Copy link
Contributor Author

benz0li commented Jun 28, 2023

@vtjnash I am currently running the MacPorts build for macOS 10.13 (High Sierra) locally.

If it succeeds, this can be merged.

src/Makefile Show resolved Hide resolved
@benz0li
Copy link
Contributor Author

benz0li commented Jun 28, 2023

@vtjnash One more thing: Is Julia for macOS 10.10+ x86-64 (64-bit) built with macOS10.15 using Xcode 12.4 12D4e and Apple clang version 12.0.0 (clang-1200.0.32.29)?

Because MacPorts builds for 'OS X'/macOS 10.10 - 10.13 (Yosemite - High Sierra) fail due to Apple clang versions < 9.3 (and MacPorts clang somehow not fully meeting the requirements).
❓ Is Julia for Linux (Glibc) 2.6.24+ x86-64 (64-bit) built using gcc?

@vtjnash vtjnash merged commit 6174056 into JuliaLang:master Jun 29, 2023
6 checks passed
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 29, 2023

It looks like it has the wrong version of LLVM, from the failure in that build log. Not sure how that could have happened though. Yes, linux is normally built with gcc (though can be built with clang).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative to copying part of a recent Xcode libSystem.tbd to src/mach_dyld_atfork.tbd
3 participants