Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowering: try to ignore special metadata nodes in tail position #49963

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented May 26, 2023

A number of packages are relying on lowering removing or ignoring line number nodes that they place in incorrect position in the AST. Accommodate those packages accordingly. See 01ddf80#commitcomment-115062034

Fix #49920

@vtjnash vtjnash added the compiler:lowering Syntax lowering (compiler front end, 2nd stage) label May 26, 2023
@vtjnash vtjnash requested a review from JeffBezanson May 26, 2023 16:28
A number of packages are relying on lowering removing or ignoring line
number nodes that they place in incorrect position in the AST.
Accommodate those packages accordingly.

Fix #49920
@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Jun 12, 2023
@vtjnash vtjnash merged commit 320e00d into master Jun 13, 2023
@vtjnash vtjnash deleted the jn/49920 branch June 13, 2023 14:33
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect lowering meta in tail position
2 participants