Add a fast-path for #49857 #49878
Merged
Add a fast-path for #49857 #49878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The union explosion is caused by the following MWE:
Type{Vector{Union{....}} <: Type{Array{T}} where {T}
280f999 only fixes for `Union{......}` without free `Typevar`. This fast-path makes sure the remaining get fixed.
|
This also seems to fix #49857 if backported to 1.9.0 with the addition of df377ad9d4dd18018bc212335a52856d2e53651b (part of which appears to already be in 1.9.0 😖). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The union explosion is caused by
Type{Vector{Union{....}} <: Type{Array{T}} where {T}280f999 only fixes for
Union{......}without freeTypevar.This PR makes sure the remaining get fixed.