Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve llvmpasses test quality #49594

Merged
merged 5 commits into from
May 2, 2023
Merged

Improve llvmpasses test quality #49594

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a33bc9b
Test missed and failed julia licm examples
pchintalapudi May 2, 2023
7875ffb
Test failed muladd optimizations
pchintalapudi May 2, 2023
33bb5b1
Convert alloc-opt-pass.jl to alloc-opt-pass.ll
pchintalapudi May 2, 2023
03c5bbc
Add explanations to the pipeline tests
pchintalapudi May 2, 2023
58a32d2
Add license headers to all llvmpasses tests
pchintalapudi May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test failed muladd optimizations
  • Loading branch information
@pchintalapudi
pchintalapudi committed May 2, 2023
commit 7875ffb59d31ec8b3808ed8ae0a47c0ed2a2b376
31 changes: 31 additions & 0 deletions test/llvmpasses/muladd.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
; RUN: opt -enable-new-pm=1 --load-pass-plugin=libjulia-codegen%shlibext -passes='CombineMulAdd' -S %s | FileCheck %s


; CHECK-LABEL: @fast_muladd1
define double @fast_muladd1(double %a, double %b, double %c) {
top:
; CHECK: {{contract|fmuladd}}
Expand All @@ -11,6 +12,7 @@ top:
ret double %v2
}

; CHECK-LABEL: @fast_mulsub1
define double @fast_mulsub1(double %a, double %b, double %c) {
top:
; CHECK: {{contract|fmuladd}}
Expand All @@ -20,6 +22,7 @@ top:
ret double %v2
}

; CHECK-LABEL: @fast_mulsub_vec1
define <2 x double> @fast_mulsub_vec1(<2 x double> %a, <2 x double> %b, <2 x double> %c) {
top:
; CHECK: {{contract|fmuladd}}
Expand All @@ -28,3 +31,31 @@ top:
; CHECK: ret <2 x double>
ret <2 x double> %v2
}

; COM: Should not mark fmul as contract when multiple uses of fmul exist
; CHECK-LABEL: @slow_muladd1
define double @slow_muladd1(double %a, double %b, double %c) {
top:
; CHECK: %v1 = fmul double %a, %b
%v1 = fmul double %a, %b
; CHECK: %v2 = fadd fast double %v1, %c
%v2 = fadd fast double %v1, %c
; CHECK: %v3 = fadd fast double %v1, %b
%v3 = fadd fast double %v1, %b
; CHECK: %v4 = fadd fast double %v3, %v2
%v4 = fadd fast double %v3, %v2
; CHECK: ret double %v4
ret double %v4
}

; COM: Should not mark fadd->fadd fast as contract
; CHECK-LABEL: @slow_addadd1
define double @slow_addadd1(double %a, double %b, double %c) {
top:
; CHECK: %v1 = fadd double %a, %b
%v1 = fadd double %a, %b
; CHECK: %v2 = fadd fast double %v1, %c
%v2 = fadd fast double %v1, %c
; CHECK: ret double %v2
ret double %v2
}