Derive T_size from DataLayout #49188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice with some context. Does this fix some issue, why is it better etc? |
|
This PR just eliminates the obvious assumptions about host pointer size/alignment in codegen, since those are available from the data layout. It's necessary for codegen on not 32/64 bit architectures, and if in the future cross compilation is supported. |
|
And making JuliaFunction a template makes it a bit cleaner? |
|
Yeah, otherwise there's a lot of JuliaFunctions with lambdas/function pointers that need to be rewritten to accept a target triple and T_size. |
vchuravy
approved these changes
Mar 31, 2023
pchintalapudi
force-pushed
the
pc/size_type
branch
from
2380159
to
aeafd10
Compare
vtjnash
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.