[LibGit2_jll] Update to v1.6.1 #48789
Conversation
giordano
added
domain:building
|
Updated and pushed |
| const libgit2 = "@rpath/libgit2.1.5.dylib" | ||
| const libgit2 = "@rpath/libgit2.1.6.dylib" | ||
| else | ||
| const libgit2 = "libgit2.so.1.5" | ||
| const libgit2 = "libgit2.so.1.6" |
There was a problem hiding this comment.
Sounds like libgit2 v1.6 has still soversion 1.5. Not sure that was done on purpose though, although it'd be great if they didn't break the ABI again.
There was a problem hiding this comment.
Might have not been done on purpose, given the fact now there's v1.6.1 which includes this: libgit2/libgit2@8a871d1
There was a problem hiding this comment.
It looks like the build product is still called libgit2.so.1.5
https://github.com/JuliaBinaryWrappers/LibGit2_jll.jl/releases/tag/LibGit2-v1.6.0%2B0
There was a problem hiding this comment.
Yeah, they tagged 1.6.0 before merging libgit2/libgit2#6501, the soversion was not bumped in v1.6.0. This has been rectified in v1.6.1.
|
New Yggdrasil PR for 1.6.1: JuliaPackaging/Yggdrasil#6313 |
|
The rebase didn't go well, this PR now includes unrelated commits |
|
Should be fixed now |
giordano
changed the title
|
Three failures:
I do not think they are related. |
|
I restarted the macOS job, second time worked like a charm. FreeBSD and PowerPC are known to have problems (and for this reason they are tier 2 or 3), and they are allowed to fail tests in CI, in fact they always fail. Thanks a lot for your work! |
Depends on JuliaPackaging/Yggdrasil#6297
Could someone remind me of the magic command to regeneratedeps/checksums/libgit2?got it:
make -f contrib/refresh_checksums.mk libgit2