Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure rename_unionall really rename all enclosing UnionAlls #48691

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Make sure rename_unionall really rename all enclosing UnionAlls #48691

merged 1 commit into from
Feb 16, 2023

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Feb 16, 2023 •
edited
Loading

follow up #48662
The previous === always return true thus we only rename the outmost typevar on master. Also add some test for this.

@N5N3
Make sure rename_unionall really rename all enclosing UnionAlls
1e6a5bc 
The previous `===` always return true thus we only rename the outmost typevar on master.
Also add some test for this.
@N5N3 N5N3 requested a review from aviatesk February 16, 2023 06:00
aviatesk
aviatesk approved these changes Feb 16, 2023
View reviewed changes
Copy link
Sponsor Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we should to make rename_unionall in C also rename all enclosing UnionAlls, or we want keep them different?

@N5N3
Copy link
Member Author

N5N3 commented Feb 16, 2023 •
edited
Loading

Subtyping handles UnionAll recursively thus rename_unionall there only needs to substitute the outmost TypeVar.
Since C's rename_unionall is now invisible for users, I think the behavior difference might be OK?

@aviatesk
Copy link
Sponsor Member

Yes, I'm fine with the different behaviors. Just wanted to check it with you.

@aviatesk aviatesk added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 16, 2023
@N5N3 N5N3 merged commit 2be7f29 into JuliaLang:master Feb 16, 2023
@N5N3 N5N3 deleted the apply_type_tfunc branch February 16, 2023 08:17
@N5N3 N5N3 removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@N5N3 @aviatesk