NFC followups on #48598 #48622
Merged
NFC followups on #48598 #48622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
approved these changes
Feb 10, 2023
base/compiler/ssair/inlining.jl
Outdated
| return ConstantCase(quoted(result.result.val)) | ||
| if is_foldable_nothrow(result.ipo_effects) | ||
| res = result.result | ||
| if isa(res, Const) && is_inlineable_constant(res.value) |
There was a problem hiding this comment.
Ah darn, I must have missed this in a rebase. Thanks!
- added missing `is_inlineable_constant` check in the inlining code of `InferenceResult` - rename `is_total` to `is_foldable_nothrow` (since `:total` subsumes the other program properties too now) - updated docstring of `Core.Compiler.finish`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_inlineable_constantcheck in the inlining code ofInferenceResultis_totaltois_foldable_nothrow(since:totalsubsumes the other program properties too now)Core.Compiler.finish