ambiguous: fix a rare case of comparison #48196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/isambiguous-better
branch
2 times, most recently
from
72b73a4
to
3cb01b0
Compare
This used to do the opposite test of what should have been required here (it checked if it was ambiguous, rather than if it was sortable). This now better aligns with the implementation in gf.c for the similar fast path check during ml_matches.
vtjnash
force-pushed
the
jn/isambiguous-better
branch
from
3cb01b0
to
27bdbf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to do the opposite test of what should have been required here
(it checked if it was ambiguous, rather than if it was sortable). This
now better aligns with the implementation in gf.c for the similar fast
path check during ml_matches.