RFC: Remove --track-allocation
#48070
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Triage says to make a post on the relevant places(Discourse/Slack etc) to ask if anyone really cares about this feature and if they don't to go ahead with removing it. |
|
Posted to slack's #general channel and discourse |
simonbyrne
added a commit
that referenced
this pull request
Feb 18, 2023
As mentioned in #48070, the allocation profiler now provides better functionality than the `--track-allocation` option. This rearranges the sections in the manual to reflect this, and adds a note to that effect. It also mentions ProfileCanvas.jl, which seems to be better supported than PProf.jl.
simonbyrne
added a commit
that referenced
this pull request
Feb 18, 2023
As mentioned in #48070, the allocation profiler now provides better functionality than the `--track-allocation` option. This rearranges the sections in the manual to reflect this, and adds a note to that effect. It also mentions ProfileCanvas.jl, which seems to be better supported than PProf.jl.
simonbyrne
added a commit
that referenced
this pull request
Feb 20, 2023
As mentioned in #48070, the allocation profiler now provides better functionality than the `--track-allocation` option. This rearranges the sections in the manual to reflect this, and adds a note to that effect. It also mentions ProfileCanvas.jl, which seems to be better supported than PProf.jl.
vchuravy
pushed a commit
that referenced
this pull request
Apr 25, 2023
As mentioned in #48070, the allocation profiler now provides better functionality than the `--track-allocation` option. This rearranges the sections in the manual to reflect this, and adds a note to that effect. It also mentions ProfileCanvas.jl, which seems to be better supported than PProf.jl.
|
What will replace this feature? I thought that Profile.Allocs requires using |
|
No, see #48713 |
|
We should do this but does not need to block 1.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Julia 1.9
--track-allocationwas one of the only ways to track where allocations where coming from in Julia.The way it functions is to change the emitted LLVM IR to insert code that tracks allocations occuring.
This often leads to false-positives since these statements interfere with optimization (in particular escape analysis)
and @simonbyrne and I once spend a particular fun couple of days hunting down ghosts.
Since it changes the emitted code it also does not particular play well with package images.
I believe there is no remaining use-case for
--track-allocationthat would not be better served by using the allocation profiler,and I am proposing to remove of the
--track-allocationfeature in 1.10.Are there users of
--track-allocationthat would object? Are there use-cases where you have fund it particular useful that are not covered by the allocation profiler?