Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for floating point exceptions #47930

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Add support for floating point exceptions #47930

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8a4a207
add exception types
simonbyrne Dec 18, 2022
1e66ad4
add to C
simonbyrne Dec 18, 2022
29f880b
add signal hooks
simonbyrne Dec 19, 2022
ce3b2c1
add Julia interface
simonbyrne Dec 19, 2022
2631abc
fix build errors
simonbyrne Dec 19, 2022
b1ba282
fix darwin
simonbyrne Dec 19, 2022
beedde6
only use feenableexcept with glibc
simonbyrne Dec 19, 2022
e024f5d
add getter
simonbyrne Dec 19, 2022
7436f34
add some tests
simonbyrne Dec 20, 2022
2a810dc
typo
simonbyrne Dec 20, 2022
f2df9d3
Merge branch 'master' into sb/sigfpe2
simonbyrne Dec 2, 2023
9b8e575
fall through
simonbyrne Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fall through
  • Loading branch information
@simonbyrne
simonbyrne committed Dec 2, 2023
commit 9b8e5755d39111293d8613be5355668efe19dfe7
4 changes: 3 additions & 1 deletion src/signals-mach.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ kern_return_t catch_mach_exception_raise(
jl_throw_in_thread(ptls2, thread, jl_inexact_fp_exception);
}
#elif defined(_CPU_AARCH64_)
// https://github.com/apple/darwin-xnu/blob/8f02f2a044b9bb1ad951987ef5bab20ec9486310/bsd/dev/i386/unix_signal.c#L535-L551
// https://github.com/apple/darwin-xnu/blob/2ff845c2e033bd0ff64b5b6aa6063a1f8f65aa32/bsd/dev/arm/unix_signal.c#L436-L459
switch (code[0]) {
case EXC_ARM_FP_UF:
jl_throw_in_thread(ptls2, thread, jl_underflow_fp_exception);
Expand All @@ -387,6 +387,8 @@ kern_return_t catch_mach_exception_raise(
default:
break;
}
#else
jl_throw_in_thread(ptls2, thread, jl_diverror_exception);
#endif
return KERN_SUCCESS;
}
Expand Down