Fix logic error in process_exited(s::ProcessChain) #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
added a commit
that referenced
this pull request
Nov 13, 2013
Fix logic error in process_exited(s::ProcessChain)
|
I can't see the context, but this still might not be quite right. Running() should be any(...) but exited() should be all(...) |
|
@vtjnash You're right, looking back that should read |
jiahao
added a commit
that referenced
this pull request
Nov 13, 2013
|
I think I see the pattern now. Please verify. |
|
Certainly correct using the semantics mentioned by @vtjnash. Not sure I like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
process_running(s::ProcessChain)andprocess_exited(s::ProcessChain)were returning identical values previously.