Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tab completion of invalid identifiers #47594

Merged
merged 5 commits into from
Nov 19, 2022
Merged

fix tab completion of invalid identifiers #47594

merged 5 commits into from
Nov 19, 2022

Conversation

oscardssmith
Copy link
Member

fixes #47593.

@KristofferC KristofferC added REPL Julia's REPL (Read Eval Print Loop) needs tests Unit tests are required for this change labels Nov 16, 2022
@DilumAluthge DilumAluthge force-pushed the oscardssmith-improve-tab-complete branch from 8dcb5f1 to 9d5282e Compare November 17, 2022 14:00
@aviatesk
Copy link
Sponsor Member

@oscardssmith Can you add a test please?

@oscardssmith
Copy link
Member Author

added.

@aviatesk aviatesk merged commit 6707077 into master Nov 19, 2022
@aviatesk aviatesk deleted the oscardssmith-improve-tab-complete branch November 19, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
needs tests Unit tests are required for this change REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REPL tab completions broken for invalid identifier names
4 participants
@oscardssmith @aviatesk @vtjnash @KristofferC