Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isunix for BinaryPlatforms AbstractPlatform #47543

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

sjkelly
Copy link
Contributor

@sjkelly sjkelly commented Nov 11, 2022

This provides symmetry with the methods defined in Sys, and is convenient for use in e.g. BinaryBuilder platform filters. Note that there are other is.*bsd variants we omit since they are unsupported by BinaryPlatforms. The capitalization conventions are also different so we do not call the Sys methods directly.

@staticfloat
Copy link
Sponsor Member

Re-running tests, now that the httpbingo problems have been fixed.

This provides symmetry with the methods defined in `Sys`,
and is convenient for use in e.g. BinaryBuilder platform filters.
Note that there are other `is.*bsd` variants we omit since they
are unsupported by BinaryPlatforms. The capitilization
conventions are also different so we do not call the Sys methods
directly.
@staticfloat staticfloat merged commit d0559c1 into JuliaLang:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants