Zlib link fix #4750
Merged
Zlib link fix #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 21, 2013 15:07
Make Intel VTune Amplifier support conditional on USE_INTEL_JITEVENTS.
This is important for linkers (such as ld on Linux) that do not scan a library listed earlier for definitions of symbols used by a library listed later.
|
Looks correct to me. cc: @staticfloat, @ViralBShah, @JeffBezanson – was the old order here intentional? |
|
Seems fine to me, but I also feel like this might have been intentional at one point. |
|
LGTM. |
|
My guess is that originally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #4742. The change puts
-ljuliabefore$(JLDFLAGS)because the former uses symbols (e.g.compress2) fromlibz.athat are satisfied by the latter ($(JLDFLAGS)contains-lz).