Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base: add new help function isdebugbuild #47475

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Base: add new help function isdebugbuild #47475

merged 3 commits into from
Nov 7, 2022

Conversation

inkydragon
Copy link
Sponsor Member

I put isdebugbuild in base/util and didn't export it.

Or define it as a new constant IS_DEBUG_BUILD.
like:

julia/base/sysinfo.jl

Line 76 in 6354e2c

const ARCH = ccall(:jl_get_ARCH, Any, ())::Symbol

fingolfin
fingolfin approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@staticfloat staticfloat merged commit 9182326 into JuliaLang:master Nov 7, 2022
@inkydragon inkydragon deleted the isdebugbuild branch November 8, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inkydragon @staticfloat @fingolfin