Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader_fputs convert to utf16 only for Windows console #47406

Merged
merged 1 commit into from
Nov 1, 2022
Merged

loader_fputs convert to utf16 only for Windows console #47406

merged 1 commit into from
Nov 1, 2022

Conversation

apaz-cli
Copy link
Member

We use loader_fputs to write error messages, and when
we write them to files we want those files to be utf8.

This should fix the broken test I introduced in #47343.

@apaz-cli
loader_fputs convert to utf16 only for win console
b7365c7 
We use loader_fputs to write error messages, and when
we write them to files we want those files to be utf8.

This should fix a broken test introduced in JuliaLang#47343.
@apaz-cli apaz-cli mentioned this pull request Oct 31, 2022
Closed
@DilumAluthge DilumAluthge added the system:windows Affects only Windows label Oct 31, 2022
@DilumAluthge DilumAluthge changed the title loader_fputs convert to utf16 only for win console loader_fputs convert to utf16 only for Windows console Oct 31, 2022
vtjnash
vtjnash reviewed Oct 31, 2022
View reviewed changes
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@vtjnash
Copy link
Sponsor Member

vtjnash commented Oct 31, 2022

CI error is #47376

inkydragon
inkydragon approved these changes Nov 1, 2022
View reviewed changes
Copy link
Sponsor Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Build with mingw64 and run test compiler/codegen works fine locally.

@vtjnash vtjnash merged commit 70ecc4b into JuliaLang:master Nov 1, 2022
@apaz-cli apaz-cli mentioned this pull request Nov 1, 2022
Merged
@vtjnash vtjnash mentioned this pull request Nov 2, 2022
Merged
vtjnash pushed a commit that referenced this pull request Nov 15, 2022
@apaz-cli
UTF16 conversion in loader uses dynamic buffers (#47421)
8d03330 
Follow up to #47406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@inkydragon inkydragon inkydragon approved these changes

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apaz-cli @vtjnash @inkydragon @DilumAluthge