cfg_simplify: Fix more bugs #47240
Merged
cfg_simplify: Fix more bugs #47240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/fixcfgsimplifymore
branch
from
6e452ae
to
0a0d7b1
Compare
Keno
commented
Oct 20, 2022
aviatesk
force-pushed
the
kf/fixcfgsimplifymore
branch
2 times, most recently
from
fd33c1d
to
9bee435
Compare
cfg_simplify still had issues with unreachable BBs, as well as BBs with try/catch in them. Additionally, it sometimes leaves unreachable BBs in the IR, which the verifier was upset about if there was a PhiNode that referenced it. I made that legal for now. The alternative is to make all unreachable BBs illegal, which I think would be reasonable, but is somewhat extreme for the time being. Let's see how this fares first.
aviatesk
force-pushed
the
kf/fixcfgsimplifymore
branch
from
9bee435
to
4863b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfg_simplify still had issues with unreachable BBs, as well as BBs with try/catch in them. Additionally, it sometimes leaves unreachable BBs in the IR, which the verifier was upset about if there was a PhiNode that referenced it. I made that legal for now. The alternative is to make all unreachable BBs illegal, which I think would be reasonable, but is somewhat extreme for the time being. Let's see how this fares first.