Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check sizes in 3-arg diagonal (dot-)product #47114

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Check sizes in 3-arg diagonal (dot-)product #47114

merged 1 commit into from
Oct 10, 2022

Conversation

dkarrasch
Copy link
Member

Fixes #47060.

@dkarrasch dkarrasch added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 kind:bugfix This change fixes an existing bug domain:linear algebra Linear algebra labels Oct 9, 2022
@dkarrasch dkarrasch requested a review from kshyatt October 9, 2022 13:28
@dkarrasch dkarrasch added the status:merge me PR is reviewed. Merge when all tests are passing label Oct 9, 2022
@oscardssmith oscardssmith merged commit 25e3809 into master Oct 10, 2022
@oscardssmith oscardssmith deleted the dk/diagsize branch October 10, 2022 02:10
@oscardssmith oscardssmith removed the status:merge me PR is reviewed. Merge when all tests are passing label Oct 10, 2022
KristofferC pushed a commit that referenced this pull request Oct 27, 2022
@dkarrasch
Check sizes in 3-arg diagonal (dot-)product (#47114)
19a17b5 
(cherry picked from commit 25e3809)
@KristofferC KristofferC mentioned this pull request Oct 27, 2022
Merged
37 tasks
KristofferC pushed a commit that referenced this pull request Oct 28, 2022
@dkarrasch @KristofferC
Check sizes in 3-arg diagonal (dot-)product (#47114)
4da1a66 
(cherry picked from commit 25e3809)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Nov 8, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@dkarrasch
Check sizes in 3-arg diagonal (dot-)product (#47114)
43a5056 
(cherry picked from commit 25e3809)
@KristofferC KristofferC mentioned this pull request Dec 21, 2022
Open
78 tasks
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@dkarrasch
Check sizes in 3-arg diagonal (dot-)product (#47114)
54e20ee 
(cherry picked from commit 25e3809)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@dkarrasch
Check sizes in 3-arg diagonal (dot-)product (#47114)
348a8a7 
(cherry picked from commit 25e3809)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@dkarrasch @staticfloat
Check sizes in 3-arg diagonal (dot-)product (#47114)
ee0b6d8 
(cherry picked from commit 25e3809)
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
@dkarrasch @KristofferC
Check sizes in 3-arg diagonal (dot-)product (#47114)
89661ac 
(cherry picked from commit 25e3809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyatt kshyatt kshyatt approved these changes

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 domain:linear algebra Linear algebra kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adjoint * Diagonal * vector does not check sizes
4 participants
@dkarrasch @kshyatt @KristofferC @oscardssmith