Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for non-linearized cglobal #47068

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Fixes for non-linearized cglobal #47068

merged 2 commits into from
Oct 6, 2022

Conversation

vchuravy
Copy link
Sponsor Member

@vchuravy vchuravy commented Oct 5, 2022 •
edited by maleadt
Loading

Fixes #46837
Fixes #45956

@vchuravy vchuravy added this to the 1.9 milestone Oct 5, 2022
@vchuravy vchuravy added the compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) label Oct 5, 2022
@maleadt maleadt marked this pull request as ready for review October 6, 2022 09:07
@maleadt
Copy link
Member

maleadt commented Oct 6, 2022

Test was bad, should have used GlobalRef(Main, :cglobal) not Main.cglobal. Fixed and rebased, should be good to go once this passes CI.

@maleadt maleadt changed the title Teach SSAIR verifier about not linearized cglobal Fixes for non-linearized cglobal Oct 6, 2022
@maleadt maleadt mentioned this pull request Oct 6, 2022
Closed
@vchuravy vchuravy merged commit 3d8eb24 into master Oct 6, 2022
@vchuravy vchuravy deleted the vc/non_linearized_cglobal branch October 6, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
compiler:optimizer Optimization passes (mostly in base/compiler/ssair/)
Projects
None yet
Milestone
1.9
2 participants
@vchuravy @maleadt