Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use grep instead of the deprecated egrep #46706

Merged
merged 1 commit into from
Sep 11, 2022
Merged

use grep instead of the deprecated egrep #46706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use grep instead of the deprecated egrep 
grep -E is the new (since POSIX) way to use the "extended" regexp.

The latest GNU Grep release complains each time egrep is invoked (egrep
is implemented as just a wrapper script around grep).

See:

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html

https://www.gnu.org/software/grep/manual/grep.html

Fixes #46649
  • Loading branch information
@nsajko
nsajko committed Sep 11, 2022
commit 45b3a89584c043eebab11823e3f39f95207f1429
2 changes: 1 addition & 1 deletion Make.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ JLDFLAGS += $(SANITIZE_LDFLAGS)
endif # SANITIZE

TAR := $(shell which gtar 2>/dev/null || which tar 2>/dev/null)
TAR_TEST := $(shell $(TAR) --help 2>&1 | egrep 'bsdtar|strip-components')
TAR_TEST := $(shell $(TAR) --help 2>&1 | grep -E 'bsdtar|strip-components')
ifeq (,$(findstring components,$(TAR_TEST)))
ifneq (bsdtar,$(findstring bsdtar,$(TAR_TEST)))
$(error "please install either GNU tar or bsdtar")
Expand Down