Expand more Vararg elements during re-intersection if valid. #46604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
force-pushed
the
Vararg_expansion2
branch
from
3f61194
to
5858740
Compare
N5N3
changed the title
N5N3
force-pushed
the
Vararg_expansion2
branch
3 times, most recently
from
a1e0565
to
2d682f7
Compare
vtjnash
force-pushed
the
Vararg_expansion2
branch
from
2d682f7
to
6b84913
Compare
vtjnash
approved these changes
Sep 28, 2022
N5N3
force-pushed
the
Vararg_expansion2
branch
from
6b84913
to
235d7fa
Compare
vtjnash
force-pushed
the
Vararg_expansion2
branch
from
235d7fa
to
fb07cd9
Compare
vtjnash
added
the
needs pkgeval
This should be valid if the type var is used only for `Vararg` length. This commit add a new field `max_offset` to our type env. which is used to tracks the minimum length of a `Vararg` during the 1st round intersection. (It's value would be set to `-1` if this var has other usage.) If we got a positive value, then we can expand more elements during the 2nd round intersection safely. With these extra elements, the offset between 2 `Vararg`s will reduce to 0 (hopefully), and thus we get a more accurate result.
N5N3
force-pushed
the
Vararg_expansion2
branch
from
fb07cd9
to
a80fc02
Compare
|
@nanosoldier |
vtjnash
added
status:merge me
|
The package evaluation job you requested has completed - possible new issues were detected. |
N5N3
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, out typeintersection "prefers"
Tuplewith more parameters.This PR tries to replace
Tuple{Vararg{T,N}}withTuple{T,T,T,Vararg{T,N}}during re-intersection if we can prove thatN >= 3andNis used only for Vararg length.It is somewhat similar to #39098 but only fucus on the expansion.
Resolve some intersection regression and this TODO from #46446.
https://github.com/JuliaLang/julia/pull/46446/files#diff-5565c704be02f2d46527b6f2f72a2c138c06d703a18e34316b6ec52b17a94bd4R2112-R2113