@noinline exp by default.
#46359
Merged
@noinline exp by default.
#46359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also remove a bunch of `@inline` from when I didn't trust the compiler to do reasonable things.
=( |
|
Why would julia chose to inline this? It seems way too big for that to happen by the normal inlining heuristics, or? |
|
nope, it has a cost of 90 which is just below the cutoff. It's a lot of code, but a lot of it is Int operations that have a cost of 1. |
35 tasks
|
From triage: seems ok, but we should also experiment with lowering the inlining cutoff --- if 90 is too expensive here, isn't it too expensive everywhere? We also no longer depend on inlining as much for constant folding, so we might not need to do so much anymore. |
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2022
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove a bunch of
@inlinefrom when I didn't trust the compiler to do reasonable things. Fixes #46323. This isn't a pure win (it will stopexpfrom auto-vectorizing) but I think it's probably the correct choice. Autovectorization seems to me to be a separate concern.