Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinearAlgebra: Handle more types as zero preserving #46340

Merged
merged 11 commits into from
Sep 13, 2022
Merged

LinearAlgebra: Handle more types as zero preserving #46340

merged 11 commits into from
Sep 13, 2022

Conversation

eschnett
Copy link
Contributor

Closes #46292

@eschnett eschnett force-pushed the eschnett/diagonal-map-zeropres branch from a78023a to 059797e Compare August 17, 2022 21:31
@eschnett
Copy link
Contributor Author

The CI errors are in InteractiveUtils and threads, and are unrelated to this PR. This is ready for review.

@eschnett
Copy link
Contributor Author

@vchuravy Could you review this again?

@giordano giordano added the domain:linear algebra Linear algebra label Aug 31, 2022
@eschnett
Copy link
Contributor Author

eschnett commented Sep 6, 2022

@vchuravy Could you review this again? The CI errors appear unrelated.

@dkarrasch dkarrasch merged commit 85fac87 into JuliaLang:master Sep 13, 2022
@eschnett eschnett deleted the eschnett/diagonal-map-zeropres branch September 13, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

@vchuravy vchuravy Awaiting requested review from vchuravy

Assignees
No one assigned
Labels
domain:linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

map for Diagonal matrix is inefficient
5 participants
@eschnett @vchuravy @dkarrasch @giordano @gbaraldi