Update README clarify build from command line #46290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed a few minor ambiguities in README: 1. Added a separate instruction to change into julia directory. It was conflated with checkout of latest release, but clearer to separate the two, since everyone needs to be in that directory regardless of whether they did a checkout. 2. Changed "from your Julia directory" to "change into the resulting julia directory" to make it clearer what directory is referred to. Changed upper- to lower-case to be consistent with subsequent references in README. 3. Rewrote instruction for `make` so that it assumes/clarifies user should already be in julia directory. 4. Same for `./julia` because user should already be in directory. 5. Removed "source" from "the julia source directory" because `make testall` should be executed from the same julia directory, and should not be confused with `src`. I have followed my updated instructions and verified that they work for myself.
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
I fixed a few minor ambiguities in README: 1. Added a separate instruction to change into julia directory. It was conflated with checkout of latest release, but clearer to separate the two, since everyone needs to be in that directory regardless of whether they did a checkout. 2. Changed "from your Julia directory" to "change into the resulting julia directory" to make it clearer what directory is referred to. Changed upper- to lower-case to be consistent with subsequent references in README. 3. Rewrote instruction for `make` so that it assumes/clarifies user should already be in julia directory. 4. Same for `./julia` because user should already be in directory. 5. Removed "source" from "the julia source directory" because `make testall` should be executed from the same julia directory, and should not be confused with `src`. I have followed my updated instructions and verified that they work for myself.
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
I fixed a few minor ambiguities in README: 1. Added a separate instruction to change into julia directory. It was conflated with checkout of latest release, but clearer to separate the two, since everyone needs to be in that directory regardless of whether they did a checkout. 2. Changed "from your Julia directory" to "change into the resulting julia directory" to make it clearer what directory is referred to. Changed upper- to lower-case to be consistent with subsequent references in README. 3. Rewrote instruction for `make` so that it assumes/clarifies user should already be in julia directory. 4. Same for `./julia` because user should already be in directory. 5. Removed "source" from "the julia source directory" because `make testall` should be executed from the same julia directory, and should not be confused with `src`. I have followed my updated instructions and verified that they work for myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a few minor ambiguities in README:
makeso that it assumes/clarifies user should already be in julia directory../juliabecause user should already be in directory.make testallshould be executed from the same julia directory, and should not be confused withsrc.I have followed my updated instructions and verified that they work for myself.