Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make exp nothrow #46238

Merged
merged 7 commits into from
Aug 4, 2022
Merged

make exp nothrow #46238

merged 7 commits into from
Aug 4, 2022

Conversation

oscardssmith
Copy link
Member

before it wasn't because the compiler can't prove that the getindex into the table is inbounds.

aviatesk
aviatesk approved these changes Aug 2, 2022
View reviewed changes
Copy link
Sponsor Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case that shows the improvement.

simeonschaub
simeonschaub reviewed Aug 3, 2022
View reviewed changes
test/math.jl Outdated Show resolved Hide resolved
aviatesk
aviatesk reviewed Aug 3, 2022
View reviewed changes
Copy link
Sponsor Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generall want to avoid accessing internals of Effects but use high-level queries instead, as the data structure isn't very stable yet.

test/math.jl Outdated Show resolved Hide resolved
@aviatesk aviatesk merged commit bc4bb1b into JuliaLang:master Aug 4, 2022
@oscardssmith oscardssmith deleted the make-exp-nothrow branch August 4, 2022 05:10
@oscardssmith
Copy link
Member Author

That's not related. That's about getfield analysis of mutable objects.

@ianatol
Copy link
Member

ianatol commented Aug 4, 2022

Oops, my mistake. I had thought the improved :consistency analysis of getfield was what allowed us to make this change --- didn't realize it wasn't applicable here

ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
@oscardssmith @simeonschaub @aviatesk
make exp nothrow (JuliaLang#46238)
d45802e 
This change allows our compiler to remove dead calls of these math ops.

Co-authored-by: Simeon Schaub <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@oscardssmith @simeonschaub
@aviatesk @pcjentsch
make exp nothrow (JuliaLang#46238)
ba1c494 
This change allows our compiler to remove dead calls of these math ops.

Co-authored-by: Simeon Schaub <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonschaub simeonschaub simeonschaub left review comments

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oscardssmith @ianatol @simeonschaub @aviatesk