effects: flip the meaning of inbounds_taint_consistency
#46179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we come up with a better name? The double negative is a bit of a mouthful. |
|
|
seems fine |
This commit renames `inbounds_taint_consistency` to `noinbounds_incosistency` so that the meaning is flipped. This should be more aligned with the other effects, where they generally mean an absence of "undesirable" properties, e.g. `nonoverlayed`.
|
Done the renaming. |
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
…46179) This commit renames `inbounds_taint_consistency` to `noinbounds` so that the meaning is flipped. This should be more aligned with the other effects, where they generally mean an absence of "undesirable" properties, e.g. `nonoverlayed`.
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
…46179) This commit renames `inbounds_taint_consistency` to `noinbounds` so that the meaning is flipped. This should be more aligned with the other effects, where they generally mean an absence of "undesirable" properties, e.g. `nonoverlayed`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames
inbounds_taint_consistencytonoinbounds_inconsistencyso that the meaning is flipped. This should be more aligned with the
other effects, where they generally mean an absence of "undesirable"
properties, e.g.
nonoverlayed.