Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump: ensure we generate the whole backedge graph #46171

Merged
merged 1 commit into from
Jul 30, 2022
Merged

dump: ensure we generate the whole backedge graph #46171

merged 1 commit into from
Jul 30, 2022

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 25, 2022

The edge-restore algorithm here is pretty bad now, but this should hopefully fix #45444

@vtjnash
dump: ensure we generate the whole backedge graph
05257f4 
The edge-restore algorithm here is pretty bad now, but this should hopefully fix #45444
@vtjnash vtjnash added the needs pkgeval Tests for all registered packages should be run with this change label Jul 25, 2022
@vtjnash
Copy link
Member Author

vtjnash commented Jul 26, 2022

@nanosoldier runtests(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@vtjnash vtjnash removed the needs pkgeval Tests for all registered packages should be run with this change label Jul 27, 2022
@vtjnash vtjnash merged commit 6b51780 into master Jul 30, 2022
@vtjnash vtjnash deleted the jn/45444 branch July 30, 2022 00:01
@timholy
Copy link
Member

timholy commented Aug 2, 2022 •
edited
Loading

Does this need backporting to 1.8? I'm guessing yes, but please remove the label if that's wrong.

@timholy timholy added the backport 1.8 Change should be backported to release-1.8 label Aug 2, 2022
@vtjnash vtjnash mentioned this pull request Aug 5, 2022
Closed
KristofferC pushed a commit that referenced this pull request Aug 6, 2022
@vtjnash @KristofferC
dump: ensure we generate the whole backedge graph (#46171)
2415a14 
The edge-restore algorithm here is pretty bad now, but this should hopefully fix #45444

(cherry picked from commit 6b51780)
@KristofferC KristofferC mentioned this pull request Aug 7, 2022
Merged
32 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Aug 7, 2022
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
@vtjnash
dump: ensure we generate the whole backedge graph (JuliaLang#46171)
2a984fc 
The edge-restore algorithm here is pretty bad now, but this should hopefully fix JuliaLang#45444
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@vtjnash @pcjentsch
dump: ensure we generate the whole backedge graph (JuliaLang#46171)
429c7fe 
The edge-restore algorithm here is pretty bad now, but this should hopefully fix JuliaLang#45444
@Keno
Copy link
Member

Keno commented Aug 18, 2022

Should we be reverting this now that the underlying issue was tracked down to a different root cause?

@vtjnash
Copy link
Member Author

vtjnash commented Sep 2, 2022

If jl_collect_backedges_to went to find the edges for something in the hashmap and it was supposed to have edges but is found to be missing instead, that is likely a bug. That is what this PR fixes some of, and what #46375 doesn't fix.

@vtjnash vtjnash mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault in jl_collect_backedges
5 participants
@vtjnash @nanosoldier @timholy @Keno @KristofferC