mark fastmath operations as not :consistent
#46143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
changed the title
:consistent:consistent
aviatesk
force-pushed
the
avi/inconsistent-fastmath
branch
from
c0d26d8
to
227ef6b
Compare
We also need to mark `muladd` as not IPO-`:consistent, but it requires to revive #31193 to preserve the currently available optimizations so I left it as TODO for now.
aviatesk
force-pushed
the
avi/inconsistent-fastmath
branch
from
227ef6b
to
94f1071
Compare
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
We also need to mark `muladd` as not IPO-`:consistent, but it requires to revive JuliaLang#31193 to preserve the currently available optimizations so I left it as TODO for now.
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
We also need to mark `muladd` as not IPO-`:consistent, but it requires to revive JuliaLang#31193 to preserve the currently available optimizations so I left it as TODO for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also need to mark
muladdas IPO-in:consistent, but it requires torevive #31193 to preserve the currently available optimizations so left
for a future PR.