Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dead comment #46132

Merged
merged 2 commits into from
Jul 23, 2022
Merged

remove dead comment #46132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eee61df
remove dead comment
aviatesk Jul 21, 2022
e91a246
make math effect-tests actually fail
aviatesk Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions test/math.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,14 +1458,7 @@ for fn in (:sin, :cos, :tan, :log, :log2, :log10, :log1p, :exponent, :sqrt, :cbr
for T in (Float32, Float64)
f = getfield(@__MODULE__, fn)
eff = Base.infer_effects(f, (T,))
if Core.Compiler.is_foldable(eff)
@test true
else
# XXX only print bad effects – especially `[sin|cos|tan](::Float32)` are analyzed
# as non-foldable sometimes but non-deterministically somehow, we need to dig
# into what's leading to the bad analysis with Cthulhu on each platform
@warn "bad effects found for $f(::$T)" eff
end
@test Core.Compiler.is_foldable(eff)
end
end
for T in (Float32, Float64)
Expand Down