In IR2OC constructor, widenconst OC argtypes #46108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
approved these changes
Jul 19, 2022
Sure that's reasonable. I also noticed that this function isn't handling |
Keno
force-pushed
the
kf/widenocargs
branch
3 times, most recently
from
ce8532f
to
44af5ea
Compare
The IR argtypes are lattice elements, but OC needs types.
aviatesk
reviewed
Jul 22, 2022
Co-authored-by: Shuhei Kadowaki <[email protected]>
aviatesk
approved these changes
Jul 22, 2022
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
* In IR2OC constructor, widenconst OC argtypes The IR argtypes are lattice elements, but OC needs types. * Update base/compiler/ssair/legacy.jl Co-authored-by: Shuhei Kadowaki <[email protected]> Co-authored-by: Shuhei Kadowaki <[email protected]>
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
* In IR2OC constructor, widenconst OC argtypes The IR argtypes are lattice elements, but OC needs types. * Update base/compiler/ssair/legacy.jl Co-authored-by: Shuhei Kadowaki <[email protected]> Co-authored-by: Shuhei Kadowaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IR argtypes are lattice elements, but OC needs types.