effects: refactor builtin_effects
#46097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/getfieldeffects
branch
from
f5d98bf
to
cfdac51
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
force-pushed
the
avi/getfieldeffects
branch
from
cfdac51
to
c962a5a
Compare
|
I'd like to merge this after #46111 to avoid manual works when backporting it. |
aviatesk
force-pushed
the
avi/getfieldeffects
branch
3 times, most recently
from
35734c0
to
5795eb0
Compare
Factor special builtin handlings into separated functions
(e.g. `getfield_effects`) so that we can refactor them more easily.
This also improves analysis accuracy a bit, e.g.
```julia
julia> Base.infer_effects((Bool,)) do c
obj = c ? Some{String}("foo") : Some{Symbol}(:bar)
return getfield(obj, :value)
end
(!c,+e,!n,+t,!s) # master
(+c,+e,!n,+t,+s) # this PR
```
aviatesk
force-pushed
the
avi/getfieldeffects
branch
from
5795eb0
to
08b4d78
Compare
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
Factor special builtin handlings into separated functions
(e.g. `getfield_effects`) so that we can refactor them more easily.
This also improves analysis accuracy a bit, e.g.
```julia
julia> Base.infer_effects((Bool,)) do c
obj = c ? Some{String}("foo") : Some{Symbol}(:bar)
return getfield(obj, :value)
end
(!c,+e,!n,+t,!s) # master
(+c,+e,!n,+t,+s) # this PR
```
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
Factor special builtin handlings into separated functions
(e.g. `getfield_effects`) so that we can refactor them more easily.
This also improves analysis accuracy a bit, e.g.
```julia
julia> Base.infer_effects((Bool,)) do c
obj = c ? Some{String}("foo") : Some{Symbol}(:bar)
return getfield(obj, :value)
end
(!c,+e,!n,+t,!s) # master
(+c,+e,!n,+t,+s) # this PR
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor special builtin handlings into separated functions
(e.g.
getfield_effects) so that we can refactor them more easily.This also improves analysis accuracy a bit, e.g.