doc: LinearAlgebra.BLAS; add compat note for spr!, spmv!, hpmv!
#45990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need v1.8+ add by: JuliaLang@ae336ab
need v1.5+ add by: JuliaLang@d8b2209
need v1.5+ add by: JuliaLang@0b034fd
inkydragon
added
domain:docs
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
…JuliaLang#45990) * doc: LinearAlgebra.BLAS; add compat note for `spr!` need v1.8+ add by: JuliaLang@ae336ab * doc: LinearAlgebra.BLAS; add compat note for `spmv!` need v1.5+ add by: JuliaLang@d8b2209 * doc: LinearAlgebra.BLAS; add compat note for `hpmv!` need v1.5+ add by: JuliaLang@0b034fd
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
…JuliaLang#45990) * doc: LinearAlgebra.BLAS; add compat note for `spr!` need v1.8+ add by: JuliaLang@ae336ab * doc: LinearAlgebra.BLAS; add compat note for `spmv!` need v1.5+ add by: JuliaLang@d8b2209 * doc: LinearAlgebra.BLAS; add compat note for `hpmv!` need v1.5+ add by: JuliaLang@0b034fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding these three functions to doc in #45978, I forgot to check for version compatibility.
spr!1.8+ae336ab
spmv!1.5+d8b2209
hpmv!1.5+0b034fd
You can check if other export functions in BLAS need to be marked for version compatibility, by looking at the last modified time of the line in the git blame: https://github.com/JuliaLang/julia/blame/master/stdlib/LinearAlgebra/src/blas.jl#L12-L63
rot!Already have a note: "requires at least Julia 1.5."