Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps/mpfr]: sync build flags with Yggdrasil/MPFR #45939

Merged
merged 7 commits into from
Sep 6, 2022

Conversation

inkydragon
Copy link
Sponsor Member

@inkydragon inkydragon commented Jul 5, 2022

@inkydragon
Copy link
Sponsor Member Author

config.sub is added in commit: efe367d

Only mpfr still need config.sub.

cp $(SRCDIR)/patches/config.sub $(SRCCACHE)/mpfr-$(MPFR_VER)/config.sub

Three years passed, and I would like to ask @Keno if we still need this patch file.

@inkydragon inkydragon added domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Jul 5, 2022
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jul 5, 2022

Three years passed, and I would like to ask @Keno if we still need this patch file.

Still needed. Looking at mpfr-4.1.0 (latest) release, it is over 2 years old and the config.sub file was old even at that time (from 2018)

@inkydragon inkydragon marked this pull request as ready for review July 7, 2022 16:52
@ViralBShah
Copy link
Member

ViralBShah commented Sep 5, 2022

@inkydragon This looks like it is good to merge. Let me know if it is. Also pinging @giordano for a quick look.

@staticfloat staticfloat merged commit 40c3645 into JuliaLang:master Sep 6, 2022
@inkydragon inkydragon deleted the source-build--mpfr branch September 6, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants