[deps/llvm] don't use hardcode LLVM_SHARED_LIB_NAME
#45908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkydragon
added
domain:building
This was referenced Jul 3, 2022
vchuravy
reviewed
Jul 3, 2022
|
Thank you for picking this up! |
staticfloat
approved these changes
Jul 4, 2022
vtjnash
reviewed
Jul 5, 2022
Comment on lines
+3
to
+4
| # import LLVM_SHARED_LIB_NAME | ||
| include $(JULIAHOME)/deps/llvm-ver.make |
There was a problem hiding this comment.
This file should not depend on deps/llvm-ver.make, since the correct value is given by llvm-config-host --version, while llvm-ver.make might not have version info (either outdated, wrong, or not available from git)
There was a problem hiding this comment.
@vtjnash But We do not call llvm-config-host here.
We only need LLVM_SHARED_LIB_NAME in main Makefile.
LLVM_SHARED_LIB_NAME <- LLVM_SHARED_LIB_VER_SUFFIX <- LLVM_VER_MAJ <- LLVM_VER
LLVM_VER: A string, updated manually.
Line 6 in c5aa255
LLVM_VER_MAJ: generated by Makefile string substitute
Line 3 in c5aa255
LLVM_SHARED_LIB_VER_SUFFIX: string concat
Line 16 in c5aa255
LLVM_SHARED_LIB_NAME: string concat
Line 18 in c5aa255
The original shared library name is a fixed string. It needs to be updated manually.
So my patch is mainly to keep the version in the lib name in sync with LLVM_VER.
If necessary I can also create a new variable and call llvm-config-host to get the correct parameters.
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
stahta01
added a commit
to stahta01/julia
that referenced
this pull request
Feb 2, 2023
stahta01
added a commit
to stahta01/julia
that referenced
this pull request
Feb 2, 2023
stahta01
added a commit
to stahta01/julia
that referenced
this pull request
Feb 2, 2023
stahta01
added a commit
to stahta01/julia
that referenced
this pull request
Feb 2, 2023
stahta01
pushed a commit
to stahta01/julia
that referenced
this pull request
Feb 5, 2023
(cherry picked from commit eb72c2a)
stahta01
pushed a commit
to stahta01/julia
that referenced
this pull request
Feb 6, 2023
(cherry picked from commit eb72c2a)
stahta01
pushed a commit
to stahta01/julia
that referenced
this pull request
Feb 6, 2023
Hand edited changes to deps/llvm.version and deps/Versions.make Moved LLVM_VER from Versions.make to llvm.version by Tim S. (cherry picked from commit eb72c2a)
stahta01
pushed a commit
to stahta01/julia
that referenced
this pull request
Feb 6, 2023
Hand edited changes to deps/llvm.version and deps/Versions.make Moved LLVM_VER from Versions.make to llvm.version by Tim S. (cherry picked from commit eb72c2a)
stahta01
pushed a commit
to stahta01/julia
that referenced
this pull request
Feb 7, 2023
Hand edited changes to deps/llvm.version and deps/Versions.make Moved LLVM_VER from Versions.make to llvm.version by Tim S. (cherry picked from commit eb72c2a)
KristofferC
pushed a commit
that referenced
this pull request
Feb 13, 2023
Hand edited changes to deps/llvm.version and deps/Versions.make Moved LLVM_VER from Versions.make to llvm.version by Tim S. (cherry picked from commit eb72c2a) Co-authored-by: woclass <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will replace #44260
$(LLVM_CONFIG_HOST) --libs --link-sharedis still broken on Windows.Related updtream issues: llvm/llvm-project#55544, llvm/llvm-project#39599