Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: rename sparam_syms to slot_syms #45876

Merged
merged 3 commits into from
Oct 31, 2023
Merged

doc: rename sparam_syms to slot_syms #45876

merged 3 commits into from
Oct 31, 2023

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Jun 30, 2022

sparam_syms was removed in #31015.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 30, 2022

Oh, I see that diff looks confusing. No, sparam_syms is gone, without direct replacement, as the information is not useful post-lowering. It can probably be reconstructed from sig however.

@vtjnash vtjnash added the docs This change adds or pertains to documentation label Jun 30, 2022
@t-bltg
Copy link
Contributor Author

t-bltg commented Jun 30, 2022

Thanks, should I close this and I leave you fix the ambiguity instead ?

@ViralBShah
Copy link
Member

What to do here next?

@t-bltg
Copy link
Contributor Author

t-bltg commented Aug 8, 2022 •
edited
Loading

No, sparam_syms is gone, without direct replacement

Let's move on this one, fixed by removing both traces of sparam_syms and slot_syms.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Oct 30, 2023
@giordano giordano merged commit b9dcb94 into JuliaLang:master Oct 31, 2023
8 checks passed
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Oct 31, 2023
@t-bltg t-bltg deleted the description branch October 31, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-bltg @vtjnash @ViralBShah @giordano