Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps/stdlib] put all version info in Versions.make #45691

Closed
wants to merge 5 commits into from

Conversation

inkydragon
Copy link
Sponsor Member

@inkydragon inkydragon commented Jun 15, 2022

I agree that there doesn't need to be both Versions.make and libname.version. We could combine the two (probably by just putting everything into Versions.make).

Originally posted by @staticfloat in #40430 (comment)

ref: #40430

  • rm all *.version files, and put all version info in Versions.make
  • fix 2 version mismatch: libblastrampoline and OpenBLAS
  • add a comment for LibSSH2, why LIBSSH2_VER !== LIBSSH2_BRANCH

Maybe we can backport this pr to other versions.

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For stdlib, we actually want to keep each of the external stdlibs in their own file. See for example #41370 (comment). So this PR undoes the work we did in #42474.

#40430 was about deps, not stdlib. Can you remove the external stdlib changes from this PR?

@inkydragon
Copy link
Sponsor Member Author

Can you remove the external stdlib changes from this PR?

There is one small problem. Because the installation of stdlib calls the function stdlib-external, which in turn calls git-external. So we can't just have stdlib use a separate .version file.

Perhaps we could reuse the deprecated arguments of the git-external function, and add a new argument use_all_in_one_version_file so that we can distinguish between deps and stdlib.

@ViralBShah ViralBShah added the domain:building Build system, or building Julia or its dependencies label Jun 15, 2022
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 15, 2022

We don't want to do this for deps either, since it means we can't determine as accurately when they need to be updated, and it increases the chances that backporting something ends up in a merge conflict. But we could probably move the BB versions into the .version files, to keep all of the ways of specifying it in one place.

@inkydragon
Copy link
Sponsor Member Author

replace by: #45720

@inkydragon inkydragon closed this Jun 17, 2022
@inkydragon inkydragon deleted the rm-libname.version branch June 28, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants