Reland " Upgrade to LLVM 14.0.2" #45679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://reviews.llvm.org/D100944 introduces will split sections if the metadata does not match. The GlobalVariables are `RW_` and the `.text` section is `R_X`. Currently there is no facility to actually mark the GV as `R_X` and we only need to write them during code-emission before we flip the permissions.
|
PkgEval run comparing assertions on the previous version of this PR vs. the commit before: 6c97a48#commitcomment-76075908. |
So no new assertion failures. |
5 tasks
giordano
reviewed
Jun 17, 2022
| @@ -101,8 +101,14 @@ void jl_init_stack_limits(int ismaster, void **stack_lo, void **stack_hi) | |||
| struct rlimit rl; | |||
| getrlimit(RLIMIT_STACK, &rl); | |||
| size_t stacksize = rl.rlim_cur; | |||
| // We intentionally leak a stack address here core.StackAddressEscape | |||
inkydragon
added a commit
to inkydragon/julia
that referenced
this pull request
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45195 contained many assertions in the package ecosystem
that were accidentially overlooked by me.
So let's calmly reland this once we figure those out.