Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static to inline statement, Fix #45181 #45564

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Add static to inline statement, Fix #45181 #45564

merged 1 commit into from
Jun 8, 2022

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Jun 2, 2022

Just inline meant the symbol did not get compiled so we got an undefined reference error.

@giordano giordano requested a review from vtjnash June 2, 2022 23:35
@giordano giordano added system:apple silicon Affects Apple Silicon only (Darwin/ARM64) - e.g. M1 and other M-series chips backport 1.8 Change should be backported to release-1.8 and removed backport 1.8 Change should be backported to release-1.8 labels Jun 2, 2022
@giordano giordano linked an issue Jun 2, 2022 that may be closed by this pull request
Apple ARM64 debug build broken #45181
Closed
@gbaraldi @maleadt
Add static to inline statement
26eb6f2 
Just inline meant the symbol did not get compiled so we got an undefined reference error
maleadt
maleadt approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to give CI another change to run, but this seems to work locally.

@maleadt maleadt added the status:merge me PR is reviewed. Merge when all tests are passing label Jun 8, 2022
@maleadt maleadt merged commit 9f26d5c into JuliaLang:master Jun 8, 2022
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label Jun 10, 2022
@NHDaly NHDaly mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
system:apple silicon Affects Apple Silicon only (Darwin/ARM64) - e.g. M1 and other M-series chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apple ARM64 debug build broken
3 participants
@gbaraldi @maleadt @giordano