Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct codegen bugs introduced by allocation-hoisting-PR #45476

Merged
merged 17 commits into from
Jul 21, 2022
Merged

correct codegen bugs introduced by allocation-hoisting-PR #45476

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4a99a31
Address reviews for older PR
gbaraldi May 27, 2022
a3cb97b
Merge branch 'master' into fix-heaphoist
gbaraldi May 27, 2022
508f292
Fix whitespace
gbaraldi May 27, 2022
ce8ff75
Correct name mangling
gbaraldi May 31, 2022
30f68bc
Implement different mangling approach
gbaraldi May 31, 2022
e366acb
Remove unused variable and small refactor
gbaraldi Jun 6, 2022
76671d1
Whitespace
gbaraldi Jun 6, 2022
ac65255
change is_promotable to field_promotable
gbaraldi Jun 9, 2022
d645429
Merge branch 'master' into fix-heaphoist
gbaraldi Jun 22, 2022
4cac1d0
Add explicit check instead of assertion
gbaraldi Jun 22, 2022
7558018
Fix the merge error ;(
gbaraldi Jun 22, 2022
e4257cb
Merge branch 'master' into fix-heaphoist
gbaraldi Jun 30, 2022
2e8363b
Explicetely not promote unions
gbaraldi Jul 2, 2022
9fcb436
Merge branch 'master' into fix-heaphoist
gbaraldi Jul 4, 2022
088b36c
Add a test for the issue found
gbaraldi Jul 6, 2022
f8f7028
Fix whitespace
gbaraldi Jul 7, 2022
d653492
Merge branch 'master' into fix-heaphoist
gbaraldi Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add explicit check instead of assertion
  • Loading branch information
@gbaraldi
gbaraldi committed Jun 22, 2022
commit 4cac1d0f1a228da452de781bc06e6236924c4c23
3 changes: 1 addition & 2 deletions src/cgutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3732,8 +3732,7 @@ static jl_cgval_t emit_new_struct(jl_codectx_t &ctx, jl_value_t *ty, size_t narg
ctx.builder.CreateAlignedStore(fval, dest, Align(jl_field_align(sty, i)))))
->setOrdering(AtomicOrdering::Unordered);
}
else if (jl_is_uniontype(jtype)) {
assert(!field_promotable);
else if (jl_is_uniontype(jtype) && !field_promotable) {
// compute tindex from rhs
jl_cgval_t rhs_union = convert_julia_type(ctx, fval_info, jtype);
if (rhs_union.typ == jl_bottom_type)
Expand Down