Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] Use newer config.sub when building nghttp2 #45346

Merged
merged 1 commit into from
May 18, 2022
Merged

[deps] Use newer config.sub when building nghttp2 #45346

merged 1 commit into from
May 18, 2022

Conversation

giordano
Copy link
Contributor

Successfully tested locally with make -C deps install-nghttp2 USE_BINARYBUILDER_NGHTTP2=0. Fix #45201. CC: @fxcoudert.

@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:apple silicon Affects Apple Silicon only (Darwin/ARM64) - e.g. M1 and other M-series chips labels May 17, 2022
@giordano giordano requested a review from staticfloat May 17, 2022 22:05
@giordano giordano added the backport 1.8 Change should be backported to release-1.8 label May 17, 2022
@staticfloat staticfloat merged commit 7f84d46 into JuliaLang:master May 18, 2022
KristofferC pushed a commit that referenced this pull request May 18, 2022
@giordano @KristofferC
[deps] Use newer config.sub when building nghttp2 (#45346)
57c884c 
(cherry picked from commit 7f84d46)
@KristofferC KristofferC mentioned this pull request May 18, 2022
Merged
67 tasks
@giordano giordano deleted the mg/nghttp2-apple-silicon branch May 18, 2022 08:18
KristofferC pushed a commit that referenced this pull request May 18, 2022
@giordano @KristofferC
[deps] Use newer config.sub when building nghttp2 (#45346)
1f9140f 
(cherry picked from commit 7f84d46)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:apple silicon Affects Apple Silicon only (Darwin/ARM64) - e.g. M1 and other M-series chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation from source on macOS fails in nghttp2
4 participants
@giordano @vtjnash @staticfloat @KristofferC