keep track of more Gcstats #45191
Merged
keep track of more Gcstats #45191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
May 4, 2022
src/gc.c
Outdated
| @@ -3067,6 +3074,7 @@ static int _jl_gc_collect(jl_ptls_t ptls, jl_gc_collection_t collection) | |||
| } | |||
|
|
|||
| // 3. walk roots | |||
| uint64_t start_mark_time = jl_hrtime(); | |||
There was a problem hiding this comment.
We should be consistent and do this next to JL_PROBE_GC_MARK_BEGIN
| @@ -3079,7 +3087,7 @@ static int _jl_gc_collect(jl_ptls_t ptls, jl_gc_collection_t collection) | |||
| gc_num.since_sweep += gc_num.allocd; | |||
| JL_PROBE_GC_MARK_END(scanned_bytes, perm_scanned_bytes); | |||
|
Time to merge this? |
vtjnash
reviewed
May 24, 2022
vtjnash
reviewed
May 24, 2022
|
Is it just time_to_safepoint (ttsp) that you don't like?
…On Tue, May 24, 2022 at 10:38 AM Jameson Nash ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In base/timing.jl
<#45191 (comment)>:
> @@ -18,9 +18,16 @@ struct GC_Num
full_sweep ::Cint
max_pause ::Int64
max_memory ::Int64
+ ttsp ::Int64
could we write out these names?
—
Reply to this email directly, view it on GitHub
<#45191 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3CLBDAJ2LMF67VMDHLOH3VLTSWBANCNFSM5VDIHXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Co-authored-by: Valentin Churavy <[email protected]>
oscardssmith
approved these changes
May 31, 2022
|
merging tomorrow sans objections. |
oscardssmith
reviewed
Jun 2, 2022
| @@ -18,9 +18,16 @@ struct GC_Num | |||
| full_sweep ::Cint | |||
| max_pause ::Int64 | |||
| max_memory ::Int64 | |||
| time_to_safepoint ::Int64 | |||
| max_time_to_safepointp ::Int64 | |||
|
Aw man, yes, sorry
…Sent from my iPhone
On Jun 1, 2022, at 11:29 PM, Oscar Smith ***@***.***> wrote:
@oscardssmith commented on this pull request.
In base/timing.jl:
> @@ -18,9 +18,16 @@ struct GC_Num
full_sweep ::Cint
max_pause ::Int64
max_memory ::Int64
+ time_to_safepoint ::Int64
+ max_time_to_safepointp ::Int64
@chflood typo?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of mark/sweep/TTSP (time to safepoint) times for reporting in benchmarks.