build: include sysimage output in timing report #45132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the time spent outputting the sysimage files isn't included in the "Total"s of each sysimage build step, yet it takes longer than the time reported.
This PR includes that time in the report.
Update: It seems from some offline discussion like the approach from #42303 might actually be ok, so I brought that here. (couldn't reopen that PR)
The approach is to introduce a
postoutput
hook that runs after any output is generated.This PR also moves the "Total" to the bottom of the report as it was noted that that might make more sense.
With this PR (updated):