hunt type instabilities within the compiler #45095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 26, 2022
|
|
||
| for infstate in InfStackUnwind(sv) | ||
| if method === infstate.linfo.def | ||
| if infstate.linfo.specTypes == sig | ||
| if infstate.linfo.specTypes === sig |
There was a problem hiding this comment.
Don't we need type-equality here?
base/compiler/inferenceresult.jl
Outdated
| @@ -106,7 +107,7 @@ function most_general_argtypes(method::Union{Method, Nothing}, @nospecialize(spe | |||
| # First, if we're dealing with a varargs method, then we set the last element of `args` | |||
| # to the appropriate `Tuple` type or `PartialStruct` instance. | |||
| if !toplevel && isva | |||
| if specTypes == Tuple | |||
| if specTypes === Tuple | |||
| if method.name === :depwarn && isdefined(Main, :Base) && method.module === Main.Base | ||
| add_remark!(interp, sv, "Refusing to infer into `depwarn`") | ||
| return MethodCallResult(Any, false, false, nothing, Effects()) | ||
| # This function is used for computing alternate limit heuristics |
There was a problem hiding this comment.
The code movement here makes the diff hard to read --- could you try arranging it differently?
Some recent PRs seems to have introduced some of those, let's get them fixed.
aviatesk
commented
May 2, 2022
Comment on lines
-211
to
-227
| # This function is used for computing alternate limit heuristics | ||
| function method_for_inference_heuristics(method::Method, @nospecialize(sig), sparams::SimpleVector) | ||
| if isdefined(method, :generator) && method.generator.expand_early && may_invoke_generator(method, sig, sparams) | ||
| method_instance = specialize_method(method, sig, sparams) | ||
| if isa(method_instance, MethodInstance) | ||
| cinfo = get_staged(method_instance) | ||
| if isa(cinfo, CodeInfo) | ||
| method2 = cinfo.method_for_inference_limit_heuristics | ||
| if method2 isa Method | ||
| return method2 | ||
| end | ||
| end | ||
| end | ||
| end | ||
| return nothing | ||
| end | ||
|
|
There was a problem hiding this comment.
Moved this function to abstractinterpretation.jl since the return value of this funciton should sync with edge_matches_sv and matches_sv.
|
@nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent PRs seems to have introduced some of those, let's get them fixed.