Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REPL] Fix a REPL test failure by removing an erroneous space in test (introduced by #33805) #44972

Merged
merged 2 commits into from
Apr 14, 2022
Merged

[REPL] Fix a REPL test failure by removing an erroneous space in test (introduced by #33805) #44972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05afef4
[REPL] remove erroneous space in test
vtjnash Apr 13, 2022
15eca34
Revert "Temporarily move the `REPL` test suite to node 1, to buy us t…
vtjnash Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/REPL/test/repl.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ fake_repl(options = REPL.Options(confirm_exit=false,hascolor=true)) do stdin_wri
write(stdin_write, ";")
readuntil(stdout_read, "shell> ")
Base.print_shell_escaped(stdin_write, Base.julia_cmd().exec..., special=Base.shell_special)
write(stdin_write, """ -e "println(\\"HI\\")\" """)
write(stdin_write, """ -e "println(\\"HI\\")\"""")
readuntil(stdout_read, ")\"")
proc_stdout_read, proc_stdout = redirect_stdout()
get_stdout = @async read(proc_stdout_read, String)
Expand Down
5 changes: 0 additions & 5 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@ move_to_node1("Distributed")
# Ensure things like consuming all kernel pipe memory doesn't interfere with other tests
move_to_node1("stress")

# TODO: remove `REPL` from the "move to node 1" tests.
# We first need to fix the underlying bugs that are causing the `REPL` tests to frequently
# fail on the `test x86_64-apple-darwin` tester on Buildkite.
move_to_node1("REPL")

# In a constrained memory environment, run the "distributed" test after all other tests
# since it starts a lot of workers and can easily exceed the maximum memory
limited_worker_rss && move_to_node1("Distributed")
Expand Down