add tuple type printing with Vararg, and port to static_show
#44970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
the
domain:display and printing
JeffBezanson
commented
Apr 13, 2022
| @@ -804,9 +835,7 @@ static size_t jl_static_show_x_(JL_STREAM *out, jl_value_t *v, jl_datatype_t *vt | |||
| n += jl_printf(out, ")"); | |||
| } | |||
| } | |||
| if (dv->parameters && (jl_value_t*)dv != dv->name->wrapper && | |||
| (jl_has_free_typevars(v) || | |||
| (jl_value_t*)dv != (jl_value_t*)jl_tuple_type)) { | |||
There was a problem hiding this comment.
I see the jl_tuple_type check was to make sure Tuple is printed as Tuple, but I don't know how the free_typevars check makes sense 🤷
vtjnash
approved these changes
Apr 13, 2022
vtjnash
added
the
status:merge me
aviatesk
approved these changes
Apr 14, 2022
DilumAluthge
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to print long tuple types with
Vararg, and adds the logic for printing asNTupleorVarargto static_show.