[LibGit2] Teach tests to be resilient to init.defaultBranch
#44629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
libgit2
vchuravy
reviewed
Mar 15, 2022
If a user runs the tests with a `~/.gitconfig` that provides an `init.defaultBranch` that is not `master`, our tests fail. Let's adjust to the user's configuration as appropriate. We'll also rename this to `default_branch` to signify that it may not be called `master` anymore.
staticfloat
force-pushed
the
sf/libgit2_main_resillience
branch
from
0fd0602
to
3f19cc3
Compare
Keno
approved these changes
Mar 15, 2022
DilumAluthge
added
the
status:merge me
|
@staticfloat Does this need backport to 1.6 and 1.7 as well? Or just 1.8? |
DilumAluthge
removed
the
status:merge me
KristofferC
pushed a commit
that referenced
this pull request
Mar 16, 2022
If a user runs the tests with a `~/.gitconfig` that provides an `init.defaultBranch` that is not `master`, our tests fail. Let's adjust to the user's configuration as appropriate. We'll also rename this to `default_branch` to signify that it may not be called `master` anymore. (cherry picked from commit ac1d693)
KristofferC
pushed a commit
that referenced
this pull request
Mar 16, 2022
If a user runs the tests with a `~/.gitconfig` that provides an `init.defaultBranch` that is not `master`, our tests fail. Let's adjust to the user's configuration as appropriate. We'll also rename this to `default_branch` to signify that it may not be called `master` anymore. (cherry picked from commit ac1d693)
|
Yeah, it wouldn't hurt |
DilumAluthge
added
backport 1.6
17 tasks
KristofferC
pushed a commit
that referenced
this pull request
Mar 25, 2022
If a user runs the tests with a `~/.gitconfig` that provides an `init.defaultBranch` that is not `master`, our tests fail. Let's adjust to the user's configuration as appropriate. We'll also rename this to `default_branch` to signify that it may not be called `master` anymore. (cherry picked from commit ac1d693)
KristofferC
added a commit
that referenced
this pull request
Mar 26, 2022
#44745) If a user runs the tests with a `~/.gitconfig` that provides an `init.defaultBranch` that is not `master`, our tests fail. Let's adjust to the user's configuration as appropriate. We'll also rename this to `default_branch` to signify that it may not be called `master` anymore. (cherry picked from commit ac1d693) Co-authored-by: Elliot Saba <[email protected]>
staticfloat
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Mar 31, 2022
In the same vein as JuliaLang/julia#44629, we need `Pkg` to look up the default branch for `git init` and use that name when performing git-based tests on a user's machine.
KristofferC
pushed a commit
that referenced
this pull request
Apr 19, 2022
If a user runs the tests with a `~/.gitconfig` that provides an `init.defaultBranch` that is not `master`, our tests fail. Let's adjust to the user's configuration as appropriate. We'll also rename this to `default_branch` to signify that it may not be called `master` anymore. (cherry picked from commit ac1d693)
This was referenced May 9, 2022
KristofferC
added a commit
that referenced
this pull request
Dec 21, 2022
#44745) If a user runs the tests with a `~/.gitconfig` that provides an `init.defaultBranch` that is not `master`, our tests fail. Let's adjust to the user's configuration as appropriate. We'll also rename this to `default_branch` to signify that it may not be called `master` anymore. (cherry picked from commit ac1d693) Co-authored-by: Elliot Saba <[email protected]>
staticfloat
added a commit
that referenced
this pull request
Dec 23, 2022
#44745) If a user runs the tests with a `~/.gitconfig` that provides an `init.defaultBranch` that is not `master`, our tests fail. Let's adjust to the user's configuration as appropriate. We'll also rename this to `default_branch` to signify that it may not be called `master` anymore. (cherry picked from commit ac1d693) Co-authored-by: Elliot Saba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user runs the tests with a
~/.gitconfigthat provides aninit.defaultBranchthat is notmaster, our tests fail. Let's adjustto the user's configuration as appropriate.