Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add underscore to punctuation.md #44552

Merged
merged 6 commits into from
May 6, 2022
Merged

Add underscore to punctuation.md #44552

merged 6 commits into from
May 6, 2022

Conversation

nathanrboyer
Copy link
Contributor

Feel free to edit as necessary.

@JeffBezanson JeffBezanson added the domain:docs This change adds or pertains to documentation label Mar 10, 2022
aviatesk
aviatesk previously requested changes Mar 11, 2022
View reviewed changes
Copy link
Sponsor Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to fix invalid references.

@nathanrboyer
Copy link
Contributor Author

I don't know how to test the references. The links I was shooting for are below:
https://docs.julialang.org/en/v1/manual/functions/#destructuring-assignment
https://docs.julialang.org/en/v1/manual/arrays/#man-comprehensions

The second link doesn't have any examples with underscores, but it seems to be common to use underscores with comprehensions.

@KristofferC KristofferC added the status:merge me PR is reviewed. Merge when all tests are passing label May 6, 2022
@KristofferC KristofferC merged commit 5bbdaa3 into JuliaLang:master May 6, 2022
@nathanrboyer nathanrboyer deleted the patch-1 branch May 6, 2022 16:40
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inkydragon inkydragon inkydragon left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@aviatesk aviatesk aviatesk left review comments

Assignees
No one assigned
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nathanrboyer @JeffBezanson @inkydragon @aviatesk @giordano @KristofferC