Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Base.return_types interface similar to code_typed #44533

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

aviatesk
Copy link
Sponsor Member

@aviatesk aviatesk commented Mar 9, 2022

Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional interp::AbstractInterpreter
argument is passed as keyword one.

/cc @maleadt this will require one-line modification in GPUCompiler code, but I'm willing to take that job if we're okay with this change.

Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional 
`interp::AbstractInterpreter`
argument is passed as keyword one.
@vtjnash vtjnash merged commit 8ee6570 into avi/partialeval Mar 10, 2022
@vtjnash vtjnash deleted the avi/returntypes branch March 10, 2022 21:13
aviatesk added a commit that referenced this pull request Mar 11, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 14, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 14, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 14, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 14, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 14, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 14, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 14, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 15, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
aviatesk added a commit that referenced this pull request Mar 15, 2022
Especially, it should be more consistent with the other reflection
utilities defined in reflection.jl if the optional
`interp::AbstractInterpreter` argument is passed as keyword one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants